[FEATURE] 카카오 OAuth 추가 #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RequestDto로 두는 것보다 VO의 개념으로 두는 것이 더 올바르다고 판단.
- 제공자 정보를 제공 받음으로 올바른 분기 처리. - OAuth2User 사용처에서 CustomOAuth2User 사용하도록 변경.
- 쿠키에는 띄어쓰기가 포함될 수 없는 문제 해결.
2 tasks
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
changed the title
github-actions
bot
changed the title
- 구글에서 카카오로 변경
Collaborator
Author
배포 서버에 카카오 관련 설정 업데이트 |
Collaborator
Author
깃허브 시크릿 업데이트 |
Collaborator
Author
테스트 업데이트 |
leebs0521
approved these changes
Jan 13, 2025
|
|
||
|
|
||
| @Test | ||
| void generateUrl_ShouldReturnCorrectUrl_ForNaver() { |
m-a-king
changed the title
ayoung-dev
approved these changes
Jan 13, 2025
Collaborator
ayoung-dev
left a comment
ayoung-dev
left a comment
There was a problem hiding this comment.
고생하셨습니다~
커밋이 잘 나눠져있어서 보기 좋았어욤
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
카카오 OAuth 로그인(회원가입) 기능을 추가했습니다.
👩💻 요구 사항과 구현 내용
카카오 OAuth 로그인(회원가입) 기능을 추가했습니다.
✅ PR 포인트 & 궁금한 점